feat(doc): support additional info from label/annotations #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This design proposal talks about how to extend the OpenSLO spec with some very useful information, which can be used in dashboards (again) or by platforms like Backstage (surprise). If you think of any more important/interesting fields, please say so :) Signed-off-by: David Jetelina <[email protected]>
fourstepper
approved these changes
Oct 30, 2023
|
I just approved this, but why is this under |
Well, it didn't feel like an ADR, or rather I didn't know how to word it as an ADR. I'm happy to rework it, suggestions are welcome. |
|
Looking at this with fresher eyes, I'm going to close this one. I think that this doesn't have to be part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design proposal talks about how to extend the OpenSLO spec with some very useful information, which can be used in dashboards (again) or by platforms like Backstage (surprise).
If you think of any more important/interesting fields, please say so :)